Skip to content

add show_undo_redo config option, default false #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexcjohnson merged 3 commits into from
May 21, 2019
Merged

add show_undo_redo config option, default false #724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b61128
add show_undo_redo config option, default false
alexcjohnson May 20, 2019
03289f6
use hide-undo-redo branch of dash-renderer
alexcjohnson May 21, 2019
a11bd7f
changelog for hide-undo-redo
alexcjohnson May 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- run:
name: Install dependencies (dash)
command: |
git clone git@github.com:plotly/dash-renderer.git
git clone -b hide-undo-redo git@github.com:plotly/dash-renderer.git
git clone git@github.com:plotly/dash-core-components.git
git clone git@github.com:plotly/dash-html-components.git
git clone git@github.com:plotly/dash-table.git
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## [UNRELEASED]
### Changed
- Undo/redo toolbar is removed by default, you can enable it with `app=Dash(show_undo_redo=true)`. The CSS hack `._dash-undo-redo:{display:none;}` is no longer needed [#724](https://github.com/plotly/dash/pull/724)

## [0.43.0] - 2019-04-25
### Changed
- Bumped dash-core-components version from 0.47.0 to [0.48.0](https://github.com/plotly/dash-core-components/blob/master/CHANGELOG.md#0480---2019-05-15)
Expand Down
5 changes: 4 additions & 1 deletion dash/dash.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def __init__(
external_stylesheets=None,
suppress_callback_exceptions=None,
components_cache_max_age=None,
show_undo_redo=False,
plugins=None,
**kwargs):

Expand Down Expand Up @@ -149,7 +150,8 @@ def __init__(
'components_cache_max_age': int(get_combined_config(
'components_cache_max_age',
components_cache_max_age,
2678400))
2678400)),
'show_undo_redo': show_undo_redo
})

assets_blueprint_name = '{}{}'.format(
Expand Down Expand Up @@ -342,6 +344,7 @@ def _config(self):
'requests_pathname_prefix': self.config.requests_pathname_prefix,
'ui': self._dev_tools.ui,
'props_check': self._dev_tools.props_check,
'show_undo_redo': self.config.show_undo_redo
}
if self._dev_tools.hot_reload:
config['hot_reload'] = {
Expand Down