Skip to content

Conversation

@mkcor
Copy link
Contributor

@mkcor mkcor commented Oct 23, 2014

This PR fixes category histograms (bar gap and x-labels).
Before: https://plot.ly/~marianne2/98
After: https://plot.ly/~marianne2/96

  • Image diffs can be seen here: 89870ed
    Look for JSON changes (i.e., test-ggplot-histogram-barmodestack.json, test-ggplot-histogram-binwidth.json, test-ggplot-histogram-dates.json) and corresponding image files, as @chriddyp suggested.

I'll increment the package version number after reviews.

/cc @pedrodz

@chriddyp
Copy link
Member

Nice! Is it possible to see how the cookbook plots changed, too?

@mkcor
Copy link
Contributor Author

mkcor commented Oct 24, 2014

Sure! They should be fixed, because this is what I get, calling ggplotly() manually:
https://plot.ly/~marianne2/100/count-vs-day/
https://plot.ly/~marianne2/99/count-vs-day/
I'll check why these two examples didn't get updated on the add-r-cookbook-tests branch.

@mkcor
Copy link
Contributor Author

mkcor commented Oct 24, 2014

@chriddyp Okay, I reran just the cookbook part and this is the resulting diff :)
a123b8b

@chriddyp
Copy link
Member

looking good!

On Fri, Oct 24, 2014 at 12:37 PM, Marianne Corvellec <
notifications@github.com> wrote:

@chriddyp https://github.com/chriddyp Okay, I reran just the cookbook
part and this is the resulting diff :)
a123b8b
a123b8b


Reply to this email directly or view it on GitHub
#133 (comment).

mkcor added a commit that referenced this pull request Oct 24, 2014
Let bargap adapt and fix x-labels in category histograms
@mkcor mkcor merged commit 7382c87 into master Oct 24, 2014
@mkcor mkcor deleted the marianne-let-bargarp branch October 24, 2014 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants