Skip to content

Fix the axes layout for facet grid/wrap. #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alyst wants to merge 2 commits into from
Closed

Fix the axes layout for facet grid/wrap. #619

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd5ab2
fix the axes layout for facet_wrap()
alyst Jun 3, 2016
d9611ae
ggplotly: fix Xaxis anchor if the last row incomplete
alyst Jun 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions R/ggplotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,10 +191,12 @@ gg2list <- function(p, width = NULL, height = NULL, tooltip = "all", source = "A

# panel -> plotly.js axis/anchor info
# (assume a grid layout by default)
panel$layout$xaxis <- panel$layout$COL
panel$layout$yaxis <- panel$layout$ROW
panel$layout$xanchor <- nRows
panel$layout$yanchor <- 1
panel$layout <- dplyr::mutate( panel$layout,
xaxis = COL, yaxis = ROW,
yanchor = 1L ) %>%
dplyr::group_by( xaxis ) %>%
dplyr::mutate( xanchor = max(ROW) ) %>% # anchor X axis to the lowest plot in the column
dplyr::ungroup() %>% as.data.frame()
if (inherits(p$facet, "wrap")) {
if (p$facet$free$x) {
panel$layout$xaxis <- panel$layout$PANEL
Expand All @@ -212,10 +214,11 @@ gg2list <- function(p, width = NULL, height = NULL, tooltip = "all", source = "A
}
}
# format the axis/anchor to a format plotly.js respects
panel$layout$xaxis <- paste0("xaxis", sub("1", "", panel$layout$xaxis))
panel$layout$yaxis <- paste0("yaxis", sub("1", "", panel$layout$yaxis))
panel$layout$xanchor <- paste0("y", sub("1", "", panel$layout$xanchor))
panel$layout$yanchor <- paste0("x", sub("1", "", panel$layout$yanchor))
plotlyjs_axis_label <- function(prefix, ixs) paste0(prefix, ifelse(as.integer(ixs) > 1, ixs, ""))
panel$layout$xaxis <- plotlyjs_axis_label("xaxis", panel$layout$xaxis)
panel$layout$yaxis <- plotlyjs_axis_label("yaxis", panel$layout$yaxis)
panel$layout$xanchor <- plotlyjs_axis_label("y", panel$layout$xanchor)
panel$layout$yanchor <- plotlyjs_axis_label("x", panel$layout$yanchor)
# for some layers2traces computations, we need the range of each panel
panel$layout$x_min <- sapply(panel$ranges, function(z) min(z$x.range))
panel$layout$x_max <- sapply(panel$ranges, function(z) max(z$x.range))
Expand Down