Spacing between bricks in a heatmap

[CalvinFernandez]

I'm trying to add spaces between bricks in my plotly heatmap to make it look like the above image. The closest workaround I've found to solving this is to implement something like http://codepen.io/etpinard/pen/dMQrKN. Would it be possible to add a padding field to the heatmap api that will specify padding for bottom, left, top and right of each heatmap brick?

[CalvinFernandez]

( @etpinard / not sure who to ping ) would someone mind taking a look here

master...CalvinFernandez:heatmap-padding

[etpinard]

@CalvinFernandez great initiative. We've been wanting to add this feature for a while now. 🍻 to that!

There a few things we should clear up before making your PR though.

• Is padding, with l, t, r and b items really necessary? I'm thinking that two attributes: one controlling horizontal padding and another for vertical padding should be enough. Unless you can convince me otherwise.
• a few other minor points that I'll make on your a508d28 commit

[CalvinFernandez]

@etpinard 👍 to horizontal and vertical.

[etpinard]

👍 to horizontal and vertical.

@CalvinFernandez Great. In this case, I would prefer a flat attribute set instead of padding container.

plotly.js has alrady a few gap attributes like bargap and boxgap So, I'd vote for hgap and vgap. But, that might not be verbose enough. @cldougl what do you think?

[CalvinFernandez]

alternatively xgap ygap is terse and clear?

[etpinard]

xgap ygap is terse and clear?

+1

[CalvinFernandez]

hey, @etpinard I addressed the comments; mind taking another look?

[etpinard]

@CalvinFernandez looks great! PR away 🚀

One thing though, when you'll make your PR, the image tests fail on CI because your newly added heatmap_brick_padding.json mock has no corresponding baseline image. If you're feeling adventurous, you can try generate that baseline image locally using our image-test docker container. See docs here. If you find that too much of a pain, I'll upload the CI artefact to the PR thread.