background color not showing in 3DMesh Plots

[Kully]

@etpinard
I noticed that the background colors for Trisurfs in Python were not their usual grey. I found a similar issue in the JS tutorial for 3D Axes and recreated the same problem in Codepen by forcing a background color of rgb(255,0,0) for illustrative purposes.

[etpinard]

Thanks. This has been broken since the 1.17.0 release.

[etpinard]

Oh. This is really unfortunate.

Looks like stackgl/gl-shader#16 is causing this issue.

Reverting back to gl-shader@4.2.0 fixes the issue. I also noticed that some tick labels aren't showing on 3D graphs on 1.17.x, reverting to gl-shader@4.2.0 also fixes that.

The worse part is that npm run test-image -- gl3d_* fails locally on master but CiricleCI fail to catch the problem - most likely it didn't properly update gl-shader to 4.2.1 during #850.

cc @monfera

[etpinard]

... maybe we should start committing an npm-shrinkwrap.json file to ensure that CircleCi run npm i when updating nested dependencies.

[etpinard]

I'm going to make a patch release after #931 is merged.

@Kully this issue will be fixed in v1.17.2

[Kully]

@Kully this issue will be fixed in v1.17.2

👍

[etpinard]

Fixed: http://codepen.io/etpinard/pen/GjokrJ