Skip to content

Pie trace cleaning#159

Merged
mdtusz merged 2 commits into
masterfrom
pie-trace-cleaning
Jan 5, 2016
Merged

Pie trace cleaning#159
mdtusz merged 2 commits into
masterfrom
pie-trace-cleaning

Conversation

@mdtusz
Copy link
Copy Markdown
Contributor

@mdtusz mdtusz commented Jan 5, 2016

Similar to the box trace cleanup.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no functions in this file, so no need for 'use strict';

That said, I don't mind making 'use strict' for all files even the one without functions.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpostlethwaite what's your take on ⏫ ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am inclined to put it everywhere so we don't have to think about it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpostlethwaite 🍻 thanks

@etpinard
Copy link
Copy Markdown
Contributor

etpinard commented Jan 5, 2016

💃

mdtusz added a commit that referenced this pull request Jan 5, 2016
@mdtusz mdtusz merged commit ecb476d into master Jan 5, 2016
@mdtusz mdtusz deleted the pie-trace-cleaning branch January 5, 2016 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants