Skip to content

Get mesh3d vertexcolor in a working state!#1686

Merged
etpinard merged 4 commits into
masterfrom
fix-mesh3d-vertexcolor
May 16, 2017
Merged

Get mesh3d vertexcolor in a working state!#1686
etpinard merged 4 commits into
masterfrom
fix-mesh3d-vertexcolor

Conversation

@etpinard
Copy link
Copy Markdown
Contributor

fixes #1684

@etpinard etpinard added status: reviewable bug something broken labels May 15, 2017
}
else if(data.vertexcolor) {
this.color = data.vertexcolors[0];
this.color = data.vertexcolor[0];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

@alexcjohnson
Copy link
Copy Markdown
Collaborator

Tetrahedra is already plural 🤓
Other than that needlessly pedantic comment, looks great! 💃

@etpinard etpinard merged commit c80aee1 into master May 16, 2017
@etpinard etpinard deleted the fix-mesh3d-vertexcolor branch May 16, 2017 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

vertexcolor for mesh3d plot does not seem to work

3 participants