Skip to content

Conversation

@etpinard
Copy link
Contributor

@etpinard etpinard commented Feb 2, 2018

This PR splits our jasmine test suites (which is getting pretty heavy 🍔 ) into 2 separate CircleCI jobs: one for our gl3d, gl2d and parcoords tests (tag @gl) and another for all the other tests that aren't skipped on CI (that @noCI tag).

This does two things:

  • speeds up our tests, they now run consistently under 10 minutes
  • (hopefully) will help us with our intermittent test failures (gl tests seem to behave better in isolated runs for some reason).

Moreover, the PR removes a few @noCI tags from our suites. Upgrading to Chrome 64 in #2323 made some tests work on CI. To note, @monfera almost all your parcoords tests are runned on CI now.

cc @alexcjohnson @dfcreative @nicolaskruchten

@alexcjohnson
Copy link
Collaborator

Nice! So previously we had:

Executed 2382 of 2454 (skipped 72)

Now we have:

Executed 2326 of 2452 (skipped 126)  // jasmine
Executed 81 of 2452 (skipped 2371)   // jasmine2, (gl)

ie total 45 skipped, or 27 more tests than we used to run on CI 🎉

Most of those are mapbox, so there are just a few that we might want to continue to investigate later.

No changes from me, this looks great! 💃

@etpinard etpinard merged commit f459723 into master Feb 5, 2018
@etpinard etpinard deleted the ci-improvements branch February 5, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants