Skip to content

Conversation

@ghtmtt
Copy link
Contributor

@ghtmtt ghtmtt commented May 14, 2018

Thanks for your interest in plotly.js!

Italian translation for plotly. Not complete (yet)

@alexcjohnson
Copy link
Collaborator

Thanks @ghtmtt - looks like you're almost there! Comparing with https://github.com/plotly/plotly.js/blob/master/dist/translation-keys.txt there are just a few more to add. Can you suggest one or two other Italian speakers to review once the last items are added?

@ghtmtt
Copy link
Contributor Author

ghtmtt commented May 15, 2018

@alexcjohnson here we go. All the translations should be updated now

Keys must match input keys exactly, and trailing colons should be preserved in the translation.
Also tweaked a couple of the comments to point to the right files
(note it's also fine to omit these comments entirely from the translation files,
as the file dist/translation-keys.txt always has up-to-date line references
as of the latest release)
@alexcjohnson
Copy link
Collaborator

Great! I just tweaked a little of the punctuation and code reference comments. Perhaps I can convince @giulioungaretti to give a quick review of these translations? 🙏

@giulioungaretti
Copy link

@alexcjohnson the translation looks spot on!

@alexcjohnson
Copy link
Collaborator

Thanks @giulioungaretti ! And thank you @ghtmtt for your contribution! 💃

@alexcjohnson alexcjohnson merged commit 42cc18d into plotly:master May 16, 2018
@ghtmtt
Copy link
Contributor Author

ghtmtt commented May 16, 2018

I'm using plotly in my https://github.com/ghtmtt/DataPlotly plugin. That's the minimum I can do for you guys ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants