Skip to content

Conversation

@archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 13, 2018

Fixes #2611.
A new attribute ortho is defined on the camera object and passed to various modules.
The scene initialisation is now uses the camera init variables and createCamera is centralised in a separate module (i.e. 3d-view) as it was used by plotly.js as well as 3d-view-controls & gl-plot3d modules.
This is a work in progress and some functions such as zooming and restyle require improvements.
Hint: to quickly test the functionality of this feature with existing 3-D mocks, one may change the dflt of ortho to be equal to true.
@etpinard

@etpinard etpinard added this to the v1.45.0 milestone Jan 24, 2019
@etpinard
Copy link
Contributor

@archmoj how close is this one to being reviewable?

@archmoj
Copy link
Contributor Author

archmoj commented Feb 12, 2019

@archmoj how close is this one to being reviewable?

@etpinard Please let me resolve the conflicts & clean up the commits in a new PR possibly tomorrow.

@etpinard
Copy link
Contributor

& clean up the commits in a new PR possibly tomorrow.

Wanna try to merge master and resolve the conflict instead? Keeping just one PR in our github history. Thanks!

@archmoj
Copy link
Contributor Author

archmoj commented Feb 18, 2019

Now in #3550
Closed.

@archmoj archmoj closed this Feb 18, 2019
@etpinard etpinard deleted the ortho-view branch February 18, 2019 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature something new

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants