Create vendor folder and fresh dist as a target only without extras including mathjax#5487
Merged
Conversation
archmoj
changed the title
…on_dist.js to run before build scripts
archmoj
commented
Feb 10, 2021
| "browserify": "^17.0.0", | ||
| "browserify-transform-tools": "^1.7.0", | ||
| "bubleify": "^2.0.0", | ||
| "canvas": "^2.6.1", |
Contributor
Author
There was a problem hiding this comment.
alexcjohnson
approved these changes
Feb 10, 2021
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Looks great - thanks for bringing back (and fixing) the requirejs test!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the previous conversation on slack,
it seems reasonable (and less confusing) to move
extras/mathjaxandtopojsontovendorfolder and start a freshdist.TODOs:
diste.g.dist/README.mdrequirejsadded in Test plotly.min.js in Require.js environment #914 so that it does not depend on the old build in dist and really tests what it should testNext steps:
mathjaxfromvendorand create a script to download, complete and updateMathJax-v2files from v2.3 to 2.7.x@plotly/plotly_js