Install MathJax using npm and bump version from 2.3 to 2.7.5#5494
Merged
Conversation
archmoj
changed the title
alexcjohnson
approved these changes
Feb 18, 2021
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Looks good. The fonts are a bit wonky in the orca images, but on the flip side it gets text alignment correct in the table mocks, which the other version doesn't. Anyway, this should be fine until we find the time to convert to Kaleido.
archmoj
commented
May 31, 2021
| "lodash": "^4.17.20", | ||
| "madge": "^3.12.0", | ||
| "mathjax": "2.7.9", | ||
| "mathjax": "2.7.5", |
Contributor
Author
There was a problem hiding this comment.
The reason why we stick to 2.7.5 for now.
@nicolaskruchten commented on slack:
Let's target 2.7.5 for MathJax for now
this is what JupyterLab 2.x uses
so it's a good floor IMO
JupyterLab 3.x is on 2.7.9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5452.
cc: #5395
TODO:
@plotly/plotly_js