Add (x|y|z)hoverformat to a number of cartesian and gl3d traces #5563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
archmoj
changed the title
Contributor
|
Can I get a Pen for this please? |
Contributor
Author
|
Contributor
|
Nice, this looks pretty much exactly like what we need :) |
archmoj
changed the title
archmoj
commented
Mar 23, 2021
| val = ax.d2l(val); | ||
| } | ||
|
|
||
| return Axes.hoverLabelText(ax, val, hoverformat); |
Contributor
Author
There was a problem hiding this comment.
Please note that Axes.hoverLabelText was not used in gl3d hover before. And for for log axes it was needed to convert the value.
alexcjohnson
reviewed
Apr 8, 2021
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
alexcjohnson
reviewed
Apr 9, 2021
archmoj
commented
Apr 9, 2021
| } | ||
| if(selection.textLabel) { | ||
| vectorTx.push(selection.textLabel); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Right above here toPrecision(3) is used for formatting norm and divergence instead of Axes.hoverLabelText. Should we keep/change that?
Collaborator
There was a problem hiding this comment.
In principle yes but that's extremely low priority IMO
alexcjohnson
reviewed
Apr 9, 2021
alexcjohnson
reviewed
Apr 9, 2021
alexcjohnson
approved these changes
Apr 9, 2021
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Looks great, just the one final case that needs a noDates
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #5552 by adding
(x|y|z)hoverformatto the following traces:scatter,histogram,bar,box,ohlc,candlestick,waterfall,funnel,violin,contour,heatmap,histogram2d,histogram2dcontour,scattergl,splom,scatter3d,mesh3d,surface,isosurface,volume,streamtubeandcone.In addition, it is now possible to use
(u|v|w)hoverformatinconeandstreamtube.@plotly/plotly_js