Set the maximum width of categorical bars & boxes to category unit - case of categoryarray#5732
Merged
Merged
Conversation
Contributor
|
Behaviour looks good. |
Contributor
|
Interestingly, box and violin don't seem to suffer from this problem even on master ... normal? |
Contributor
Author
Positive. Thanks for checking. |
|
|
||
| var type = (opts.posAxis || {}).type; | ||
| if(type === 'category' || type === 'multicategory') { | ||
| this.minDiff = Math.min(1, this.minDiff); |
Collaborator
There was a problem hiding this comment.
This looks like a great solution, and simpler than the previous logic. My only question is whether there's actually a benefit of doing Math.min vs just minDiff = 1 in the (multi)category case? There's no way to specify input data that will result in non-integer positions here, is there?
alexcjohnson
approved these changes
Jun 17, 2021
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 after considering https://github.com/plotly/plotly.js/pull/5732/files#r653694361
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5731.
@plotly/plotly_js