Use npm v7 and node.js 16 in development and testing#5922
Conversation
| 'outsidetextfont.size': 12 | ||
| }, { | ||
| t: '~=', l: '~=', | ||
| t: '~=', l: 'shrunk', |
There was a problem hiding this comment.
Bring back the original test which was tweaked in e01d09a.
| }); | ||
|
|
||
| it('panning a matching overlaying axis', function(done) { | ||
| it('@noCI panning a matching overlaying axis', function(done) { |
There was a problem hiding this comment.
Instead of @noCI can we just increase the tolerance a bit?
There was a problem hiding this comment.
This test passes locally. We did reduce the number of noCI test when compared to pre-v2 era.
I hope in near future we could spend some time to bring that down to zero.
This is I think possible by ensuring the needed fonts installed in the jasmine containers.
So if you don't mind I keep this flag and instead open an issue to track it?
There was a problem hiding this comment.
Sure, that's fine. Thanks for the tracking issue.
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Looks good - if we can avoid adding another @noCI that would be great, but don't need to spend a lot of time on that now.
2 participants
Supersedes #5921 and fixes the issue with listing forked modules required to address #897.
@plotly/plotly_js