Skip to content

Add support for trace opacity in toself fills#896

Merged
etpinard merged 3 commits into
masterfrom
toself-trace-opacity
Sep 7, 2016
Merged

Add support for trace opacity in toself fills#896
etpinard merged 3 commits into
masterfrom
toself-trace-opacity

Conversation

@etpinard
Copy link
Copy Markdown
Contributor

@etpinard etpinard commented Sep 1, 2016

resolves #884

As mentioned in #884, trace opacity for scatter trace with non-'none' fills are not honoured in the drawing code. This decision was made back in 2015 to (in brief) make sure the opacity of tonext* trace couplets do not become inconsistent.

But, that old fix for the above edge cases do not apply to toself fills which was added in 1.10.0.

This PR makes trace opacity be honoured for toself fills.

@etpinard etpinard added bug something broken status: reviewable labels Sep 1, 2016
@etpinard etpinard added this to the v1.17.0 milestone Sep 1, 2016
@mdtusz
Copy link
Copy Markdown
Contributor

mdtusz commented Sep 7, 2016

lgtm! 💃

@etpinard etpinard merged commit 76f1c57 into master Sep 7, 2016
@etpinard etpinard deleted the toself-trace-opacity branch September 7, 2016 15:56
@tsando
Copy link
Copy Markdown

tsando commented Jan 30, 2018

Is there any way to set the opacity for tonexty? This example only seems to cover toself and I'm still having the bug if using tonexty. Only way to set opacity is to use toself. Thanks

@etpinard
Copy link
Copy Markdown
Contributor Author

@tsando

Is there any way to set the opacity for tonexty?

No. We explicitly unset it here as it can lead to unwanted effects. The behavior can be seen here.

To adjust tonext* fill transparencies, use the alpha channel the fillcolor e.g. 'rgba(255,0,0,0.2)'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Marker/line opacity unaffected by restyle when fill=toself

3 participants