Skip to content

Remove calls to non-existent figure methods in MPL code #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonmmease merged 2 commits into from
Dec 29, 2018
Merged

Remove calls to non-existent figure methods in MPL code #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67253c4
Remove call to `fig.strip_style` (was removed in v3)
jonmmease Dec 29, 2018
ea3bda8
Remove call to `fig.validate` (was removed in v3)
jonmmease Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions plotly/matplotlylib/renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,5 +735,4 @@ def resize(self):
pass

def strip_style(self):
self.msg += "Stripping mpl style, deleting keys from data and layout\n"
self.plotly_fig.strip_style()
self.msg += "Stripping mpl style is no longer supported\n"
1 change: 0 additions & 1 deletion plotly/plotly/plotly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,6 @@ def iplot_mpl(fig, resize=True, strip_style=False, update=None,
fig = tools.mpl_to_plotly(fig, resize=resize, strip_style=strip_style)
if update and isinstance(update, dict):
fig.update(update)
fig.validate()
elif update is not None:
raise exceptions.PlotlyGraphObjectError(
"'update' must be dictionary-like and a valid plotly Figure "
Expand Down