Skip to content

Fix CI failure #4728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marthacryan merged 1 commit into from
Aug 26, 2024
Merged

Fix CI failure #4728

marthacryan merged 1 commit into from
Aug 26, 2024
+2 −0

Conversation

@marthacryan
Copy link
Collaborator

@marthacryan marthacryan commented Aug 26, 2024

Fixes the failing CI based on suggestions in this comment.

@gvwilson gvwilson requested a review from BRONSOLO August 26, 2024 20:39
@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken infrastructure build process etc. labels Aug 26, 2024
@BRONSOLO
Copy link
Member

BRONSOLO commented Aug 26, 2024 •
edited
Loading

I suggest @LiamConnors should review : ) Removing my assignment (though code changes look OK to me in general)

@BRONSOLO BRONSOLO requested review from LiamConnors and removed request for BRONSOLO August 26, 2024 21:03
archmoj
archmoj approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the fix.
Looking good to me.
@LiamConnors Wondering this might be something we should also add to the release process?

💃

@marthacryan marthacryan merged commit 93fcdb2 into master Aug 26, 2024
@marthacryan marthacryan deleted the ci-failure branch August 26, 2024 21:54
@LiamConnors
Copy link
Member

LiamConnors commented Aug 27, 2024

Thanks very much for the fix. Looking good to me. @LiamConnors Wondering this might be something we should also add to the release process?

💃

@archmoj which part of the release process might benefit from adding something based on this? I thought this PR fixes it

@archmoj
Copy link
Contributor

archmoj commented Aug 27, 2024

Thanks very much for the fix. Looking good to me. @LiamConnors Wondering this might be something we should also add to the release process?
💃

@archmoj which part of the release process might benefit from adding something based on this? I thought this PR fixes it

Just in case you noticed a similar bug during the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LiamConnors LiamConnors Awaiting requested review from LiamConnors

1 more reviewer

@archmoj archmoj archmoj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marthacryan marthacryan

Labels

fix fixes something broken infrastructure build process etc. P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@marthacryan @BRONSOLO @LiamConnors @archmoj @gvwilson