simple_captcha_data: ignore all error during data flushing#69
Open
p1-ra wants to merge 1 commit intopludoni:masterfrom
Open
simple_captcha_data: ignore all error during data flushing#69p1-ra wants to merge 1 commit intopludoni:masterfrom
p1-ra wants to merge 1 commit intopludoni:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for MySQL2:Error that happens times to times after call to
#simpla_captcha_passed!on call ofSimpleCaptchaData#remove_data.The issue only occurs on my CI, I can't reproduce it outside of it and I don't have enough context to fully understand what and why, but it is a less big deal to have remaining data in the DB times to times than raising an exception killing the current request handler if the DB clean-up fail.
In case someone wants to investigate deeper:
