This repository was archived by the owner on Jul 4, 2022. It is now read-only.
Merged
Conversation
hoani
approved these changes
Mar 4, 2020
Contributor
hoani
left a comment
hoani
left a comment
There was a problem hiding this comment.
LGTM - no issues found in frame_system or primitives/runtime/src/testing.rs
cowboy-bebug
approved these changes
Mar 4, 2020
Contributor
cowboy-bebug
left a comment
cowboy-bebug
left a comment
There was a problem hiding this comment.
LGTM! The changes in frame_system and primitives/runtime/src/testing.rs were mostly refactors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed history version of
developbranch with latest upstream changesNotable differences to upstream runtime:
The main place to review would be the
frame_systemmodule andprimitives/runtime/src/testing.rschanges around theTestXttype.Most conflicts were dependency name updates, spelling fixes, and reversions of stuff mentioned above
This will become the new develop trunk it won't be merged