-
Notifications
You must be signed in to change notification settings - Fork 0
Add about page and navigation link #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| --- | ||
| import PageLayout from "@layouts/PageLayout.astro"; | ||
| import Container from "@components/Container.astro"; | ||
| import Link from "@components/Link.astro"; | ||
| import { SITE, SOCIALS } from "@consts"; | ||
| import { getHomeOGData } from "@lib/opengraph"; | ||
|
|
||
| const ogData = getHomeOGData( | ||
| Astro.url.toString(), | ||
| Astro.site?.toString() || "" | ||
| ); | ||
| --- | ||
|
|
||
| <PageLayout title="About" description="About Dispatches and its author" ogData={ogData}> | ||
| <Container> | ||
| <div class="space-y-10"> | ||
| <h1 class="animate font-semibold text-black dark:text-white"> | ||
| About | ||
| </h1> | ||
|
|
||
| <div class="space-y-4"> | ||
| <section class="animate space-y-4"> | ||
| <h2 class="font-semibold text-black dark:text-white">About Dispatches</h2> | ||
| <article class="prose dark:prose-invert"> | ||
| <p> | ||
| <em>Dispatches</em> is where I publish technical writing on topics of personal interest. | ||
| During this initial phase, much of the content will be "refurbished-and-expanded": older | ||
| personal notes or explanations, updated and expanded where necessary. | ||
| </p> | ||
| <p> | ||
| Expect a focus on Swift, lower-level iOS work, and—as of late—agentic coding assistants. | ||
| </p> | ||
| </article> | ||
| </section> | ||
|
|
||
| <section class="animate space-y-4"> | ||
| <h2 class="font-semibold text-black dark:text-white">Connect</h2> | ||
| <article> | ||
| <p class="mb-4">Feel free to reach out:</p> | ||
| <ul class="flex flex-wrap gap-2"> | ||
| {SOCIALS.map(SOCIAL => ( | ||
| <li class="flex gap-x-2 text-nowrap"> | ||
| <Link href={SOCIAL.HREF} external aria-label={`${SITE.NAME} on ${SOCIAL.NAME}`}> | ||
| {SOCIAL.NAME} | ||
| </Link> | ||
| </li> | ||
| ))} | ||
| </ul> | ||
| </article> | ||
| </section> | ||
| </div> | ||
| </div> | ||
| </Container> | ||
| </PageLayout> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using
getHomeOGDatahere causes/aboutto publish homepage OpenGraph fields (title/descriptionare hardcoded insrc/lib/opengraph.ts), andHead.astroprefers providedogDataover the page props, so sharing/aboutwill show homepage preview text instead of About-page metadata. This impacts SEO/social previews specifically when the About URL is crawled or shared.Useful? React with 👍 / 👎.