Added Int32 and Int64 and Boolean Datatypes

[pmdevers]

Summary by CodeRabbit

• New Features
  • Enhanced schema configuration by allowing users to specify nullability for properties. This update provides more flexible handling of schema fields for text, numeric, and boolean values.

[coderabbitai]

Walkthrough

The OfType<TBuilder> method in the CustomResourceDefinitionBuilderExtensions class has been updated. An optional parameter nullable (of type bool? with a default value of false) has been added. The method logic now uses this parameter to set the schema's nullability for types such as string, integer (Int32 and Int64), and boolean. Additionally, when encountering a nullable generic type, the method makes a recursive call with nullable set to true.

Changes

File	Change Summary
src/.../CustomResourceDefinitionBuilderExtensions.cs	Method Signature Updated: Added parameter bool? nullable = false. Logic Modified: Sets schema.Nullable based on nullable for string, integer, and boolean types; recursive calls now pass true for nullable generic types.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Builder
    participant TypeChecker

    Caller->>Builder: Call OfType(builder, type, nullable)
    Builder->>TypeChecker: Check type (string/int/bool/etc.)
    alt Type is Nullable Generic
        Builder->>Builder: Recursive call with nullable=true
    else
        TypeChecker-->>Builder: Return type info with nullable parameter
        Builder->>Schema: Set schema.Nullable = nullable
    end
    Builder-->>Caller: Return updated builder

Loading

Poem

I'm a rabbit coding under the moonlight glow,
Hopping through changes, letting new ideas flow.
A nullable carrot now decorates our schema row,
Recursive hops and type checks in a neat little show.
From CodeRabbit Inc., our code continues to grow!
🥕🐇 Happy coding and bouncy days ahead!

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/K8sOperator.NET.Generators/Builders/CustomResourceDefinitionBuilderExtensions.cs (2)

222-222: Complete the XML documentation for the 'nullable' parameter.

The XML documentation for the nullable parameter is incomplete. Please add a description that explains its purpose - it controls whether the schema property should allow null values.

-    /// <param name="nullable"></param>
+    /// <param name="nullable">A value indicating whether the schema property allows null values.</param>

---

225-271: Implementation of Int32, Int64, and Boolean datatypes looks good!

The added support for Int32, Int64, and Boolean datatypes is implemented correctly. The approach of passing the nullability parameter through to the schema configuration is consistent with the existing String type handling.

I noticed that the implementation for Int32 and Int64 is identical - both set x.Type = "integer". This is correct for OpenAPI/Kubernetes schema definitions, but you might consider adding a format constraint to differentiate them:

            builder.Add(x =>
            {
                x.Type = "integer";
+               x.Format = "int32";
                x.Nullable = nullable;
            });

For Int64:

            builder.Add(x =>
            {
                x.Type = "integer";
+               x.Format = "int64";
                x.Nullable = nullable;
            });

This would more accurately represent the data types in the OpenAPI schema.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8bb13fe and 6cc86c4.

📒 Files selected for processing (1)

• src/K8sOperator.NET.Generators/Builders/CustomResourceDefinitionBuilderExtensions.cs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze

🔇 Additional comments (1)

src/K8sOperator.NET.Generators/Builders/CustomResourceDefinitionBuilderExtensions.cs (1)

268-271: Good handling of Nullable generic types.

The implementation correctly handles nullable generic types by making a recursive call with nullable set to true. This ensures that nullable value types are properly represented in the schema.