feat: raw mode preserve original formats#49
Merged
realfishsam merged 13 commits intopmxt-dev:mainfrom Mar 13, 2026
Merged
Conversation
raw/normalized modes
Contributor
|
I'll review asap. |
Reverts all raw-price-mode commits from the PR. The mode option, RequestOptions threading, and all raw/normalized branching have been removed from core, TypeScript SDK, Python SDK, tests, and docs. Reverted commits (newest → oldest): - 4f66c4a docs(python-sdk): document raw mode usage - e316eb2 test(python-sdk): add raw mode args coverage - 495032e feat(python-sdk): add raw price mode support - 102529d docs: document raw mode in README/api docs - 1d8b834 test(sdk-typescript): add unit tests for args helper - 19ccfc4 feat(sdk-typescript): support raw mode in optional request args - bc5369a test(core): cover raw-mode price helpers - 5d492a4 refactor(core): extract reusable price conversion helpers - 5ab0ca4 feat(core): add raw mode request option to exchange API
- Add kalshi/price.ts: fromKalshiCents, invertKalshiCents, invertKalshiUnified - Add baozi/price.ts: clampBaoziPrice, normalizeBaoziOutcomes - Add myriad/price.ts: resolveMyriadPrice - Update utils/exchange files to use the helpers instead of inline math - Add args.ts to TypeScript SDK: buildArgsWithOptionalOptions helper - Update client.ts to use the args helper consistently - Improve Python SDK typing for since/until params (Optional[Union[datetime, int, float, str]] instead of Optional[Any]) - Add unit tests for all price helpers and args helper
Contributor
Author
|
Should I resolve conflicts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal if this PR is to add a
rawmode that allows to skip price normalization if user wants the raw data from the original exchange.For this, I've made the following changes.
Changes
moderequest option support (normalizedby default, andrawas an opt-in).Refactor
I've also refactored some code as noted above. Here are the main changes. Of course, not everything here is really needed specifically for this issue but helps making the codebase better over the long term.
Any, explicit datetime handling, etc).Test
I've updated tests too but I need API keys for proper testing, I guess the CI will ensure proper testing and I might fix some code if it doesn't pass.