Skip to content

Conversation

@alexhutko
Copy link
Contributor

High priority- add NRCAN datacenter, QW and QX networks and other new networks from branch alexhutko-patch-5 that never found their way in.

Add NRCAN datacenter, QW and QX networks and other new networks from branch alexhutko-patch-5 that never found their way in.
Copy link
Collaborator

@ulbergc ulbergc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ulbergc ulbergc self-requested a review March 8, 2024 19:53
@ulbergc
Copy link
Collaborator

ulbergc commented Mar 8, 2024

Actually, I see it failed the build because of too long lines:

./nslc/management/commands/load_from_fdsn.py:134:80: E501 line too long (95 > 79 characters)
./nslc/management/commands/load_from_fdsn.py:135:80: E501 line too long (95 > 79 characters)
./nslc/management/commands/load_from_fdsn.py:135:96: W291 trailing whitespace
./nslc/management/commands/load_from_fdsn.py:136:80: E501 line too long (95 > 79 characters)
./nslc/management/commands/load_from_fdsn.py:136:96: W291 trailing whitespace
./nslc/management/commands/load_from_fdsn.py:137:80: E501 line too long (95 > 79 characters)
./nslc/management/commands/load_from_fdsn.py:137:96: W291 trailing whitespace
./nslc/management/commands/load_from_fdsn.py:138:80: E501 line too long (95 > 79 characters)
./nslc/management/commands/load_from_fdsn.py:139:59: W291 trailing whitespace

Can you resubmit with the network lines (134-139) shorter than 80 characters, and make sure not to have whitespace at the end of each line?

Limited lines to less than 79 characters.
Copy link
Collaborator

@ulbergc ulbergc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good x2

@ulbergc ulbergc merged commit d0369bc into main Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants