Fix bug that reset timestamp of record when sharing.#278
Merged
Conversation
mbrandonw
commented
Oct 27, 2025
| │ ) │ | ||
| └────────────────────────────────────────────────────────────────────────┘ | ||
| ┌────────────────────────────────────────────────────────────────────────┬───┐ | ||
| │ CKRecord( │ 0 │ |
Member
Author
There was a problem hiding this comment.
Previously this test would have snapshot -1 for the timestamp.
stephencelis
approved these changes
Oct 27, 2025
bok-
pushed a commit
to bok-/sqlite-data-with-traits
that referenced
this pull request
Dec 15, 2025
* Fix bug that reset timestamp of record when sharing. * wip * Clean up' * clean up * wip * test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we accidentally reset the
userModificationTimeon a record's metadata when it is shared because theshare(record:)method is only dealing with a system fieldsCKRecord. So let's go ahead and fetch the full record when sharing so that we have the most recent timestamps.