Skip to content

Fix issues with CK{Record,Share}.SystemFieldsRepresentation #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephencelis merged 4 commits into from
Oct 30, 2025
Merged

Fix issues with CK{Record,Share}.SystemFieldsRepresentation #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f24f4e3
Fix issues with `CK{Record,Share}.SystemFieldsRepresentation`
stephencelis Oct 30, 2025
00897f1
Compile time tests
mbrandonw Oct 30, 2025
c6cbdba
wip;
mbrandonw Oct 30, 2025
ae0a29c
wip
mbrandonw Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion Examples/Examples.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 2 additions & 6 deletions Sources/SQLiteData/CloudKit/CloudKit+StructuredQueries.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
import CryptoKit
import StructuredQueriesCore

extension _CKRecord where Self == CKRecord {
extension CKRecord {
public typealias _AllFieldsRepresentation = SQLiteData._AllFieldsRepresentation<CKRecord>
public typealias SystemFieldsRepresentation = _SystemFieldsRepresentation<CKRecord>
}

extension _CKRecord where Self == CKShare {
extension CKShare {
public typealias _AllFieldsRepresentation = SQLiteData._AllFieldsRepresentation<CKShare>
public typealias SystemFieldsRepresentation = _SystemFieldsRepresentation<CKShare>
}
Expand Down Expand Up @@ -102,10 +102,6 @@
private struct DecodingError: Error {}
}

extension CKRecord: _CKRecord {}

public protocol _CKRecord {}

extension CKDatabase.Scope {
public struct RawValueRepresentation: QueryBindable, QueryRepresentable {
public let queryOutput: CKDatabase.Scope
Expand Down
34 changes: 34 additions & 0 deletions Tests/SQLiteDataTests/CompileTimeTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,43 @@
import SQLiteData

#if canImport(CloudKit)
import CloudKit
#endif

private final class Model {
@FetchAll var titles: [String]

init() {
_titles = FetchAll(Reminder.select(\.title))
}
}

#if canImport(CloudKit)
@Table
struct RepresentableFields {
@Column(as: CKShare.SystemFieldsRepresentation.self)
var share: CKShare
@Column(as: CKShare?.SystemFieldsRepresentation.self)
var optionalShare: CKShare?
@Column(as: CKRecord.SystemFieldsRepresentation.self)
var record: CKRecord
@Column(as: CKRecord?.SystemFieldsRepresentation.self)
var optionalRecord: CKRecord?
}

@DatabaseFunction(
as: ((
CKShare.SystemFieldsRepresentation,
CKRecord.SystemFieldsRepresentation,
CKShare?.SystemFieldsRepresentation,
CKRecord?.SystemFieldsRepresentation
) -> Void).self
)
nonisolated func representableArguments(
share: CKShare,
record: CKRecord,
optionalShare: CKShare?,
optionalRecord: CKRecord?
) {
}
#endif