Add indexes on foreign keys in Reminders and SyncUp examples#317
Merged
Conversation
mbrandonw
reviewed
Dec 2, 2025
Comment on lines
+233
to
+239
| try #sql( | ||
| """ | ||
| CREATE INDEX IF NOT EXISTS "idx_remindersListAssets_remindersListID" | ||
| ON "remindersListAssets"("remindersListID") | ||
| """ | ||
| ) | ||
| .execute(db) |
Member
There was a problem hiding this comment.
I believe this one is not necessary because remindersListID is the primary key and so already indexed.
…ndersListID is the primary key and so already indexed.
mbrandonw
approved these changes
Dec 2, 2025
bok-
pushed a commit
to bok-/sqlite-data-with-traits
that referenced
this pull request
Dec 15, 2025
…eeco#317) * Add indexes on foreign keys in Reminders and SyncUp examples * idx_remindersListAssets_remindersListID is not necessary because remindersListID is the primary key and so already indexed. * F**. fix last fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds index to foreign-key columns in the SQLiteData Reminders and SyncUp examples, as Brandon requested in Slack. Good practice to help query performance.