Fix id column type in documentation example schema to prevent error#322
Merged
Merged
Conversation
When the `id` column is defined as `INT NOT NULL PRIMARY KEY AUTOINCREMENT` sqlite will throw an error: > AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY
mbrandonw
approved these changes
Dec 5, 2025
Member
mbrandonw
left a comment
mbrandonw
left a comment
There was a problem hiding this comment.
Hi @RobbieClarken, good catch!
mbrandonw
pushed a commit
that referenced
this pull request
Dec 5, 2025
…322) When the `id` column is defined as `INT NOT NULL PRIMARY KEY AUTOINCREMENT` sqlite will throw an error: > AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY
mbrandonw
added a commit
that referenced
this pull request
Dec 8, 2025
* Private tables should always be saved in private db. * snapshots * Handle shared database more correctly. * wip * fix test * add another test * Update Tests/SQLiteDataTests/CloudKitTests/MockCloudDatabaseTests.swift * Fix id column type in documentation example schema to prevent error (#322) When the `id` column is defined as `INT NOT NULL PRIMARY KEY AUTOINCREMENT` sqlite will throw an error: > AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY * fixes * format --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> Co-authored-by: Robbie Clarken <last.gem5797@invariance.io>
bok-
pushed a commit
to bok-/sqlite-data-with-traits
that referenced
this pull request
Dec 15, 2025
…ointfreeco#322) When the `id` column is defined as `INT NOT NULL PRIMARY KEY AUTOINCREMENT` sqlite will throw an error: > AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY
bok-
pushed a commit
to bok-/sqlite-data-with-traits
that referenced
this pull request
Dec 15, 2025
* Private tables should always be saved in private db. * snapshots * Handle shared database more correctly. * wip * fix test * add another test * Update Tests/SQLiteDataTests/CloudKitTests/MockCloudDatabaseTests.swift * Fix id column type in documentation example schema to prevent error (pointfreeco#322) When the `id` column is defined as `INT NOT NULL PRIMARY KEY AUTOINCREMENT` sqlite will throw an error: > AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY * fixes * format --------- Co-authored-by: Stephen Celis <stephen@stephencelis.com> Co-authored-by: Robbie Clarken <last.gem5797@invariance.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
idcolumn is defined asINT NOT NULL PRIMARY KEY AUTOINCREMENTsqlite will throw an error:This is fixed by changing
INTtoINTEGER. I also changed the other columns for consistency.The error was being thrown for sqlite-data 1.4.0, iOS 26.1.