Revert to upstream keytar to fix broken x86 macOS build#93
Merged
pol-rivero merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CI workflow to explicitly rebuild the keytar-forked-forked native module during the build job, intended to ensure the module is built correctly for x86 (x64) macOS targets.
Changes:
- Add a CI step to run
@electron/rebuildforkeytar-forked-forked. - Parameterize the rebuild by the matrix architecture (
${{ matrix.arch }}).
pol-rivero
force-pushed
the
test-keytar-rebuild
branch
2 times, most recently
from
4f3c308 to
62d2319
Compare
keytar-forked-forked seems to be broken in x86 macOS (actually compiled as arm64). Support for 32-bit arm is no longer required.
pol-rivero
force-pushed
the
test-keytar-rebuild
branch
from
62d2319 to
c39be71
Compare
pol-rivero
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.