Add support for XDP egress programs #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frisso
approved these changes
Apr 6, 2020
sebymiano
requested changes
Apr 7, 2020
Collaborator
sebymiano
left a comment
sebymiano
left a comment
There was a problem hiding this comment.
@FedeParola the PR looks very good to me! Thanks.
I have only the last effort to ask you (I know that would be very boring) but, can you please add some tests to check if the chain is done correctly?
For example, you can print the log and check if it is similar to the expected one.
In this way, we can avoid this kind of bugs in the future.
- Test packet flowing beetwen two namespaces - Test packet flowing out of the network stack
frisso
approved these changes
Apr 24, 2020
sebymiano
approved these changes
Apr 25, 2020
frisso
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for XDP egress programs.
Currently egress code of both standard and transparent cubes is only injected in TC mode, therefore it cannot be executed when a packet comes from a XDP hook.
With this patch two versions of every egress program are injected, sharing the same maps:
The patch also fixes some bugs related to cubes chaining and exchanging packets between the controller and the fastpath.
Fixes #280