Better error messages for corrupt namespaces #547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add additional assertion for empty file - Add test for corrupt file - Rename test namespace
Collaborator
|
Replaced by PR #548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Rebased version of #546)
Fixes #523
Most of the code was generated by Claude Sonnet 3.7 and clojure-mcp*
I've reviewed the code, improved it slightly, removed unnecessary whitespace changes, and manually tested it on the https://github.com/jeroenvandijk/clojure-polylith-realworld-example-app/ project, see screenshots below.
Corrupt file
Empty file
I believe the code is somewhat in the style of the rest of the Polylith code. Please note that I have considered creating a PR before without the help of AI, but because of my relative unfamiliarity with the project I didn't find a fix that time. So Claude helped me find a solution here, but I don't know if this is the best way to go about it. Since most of the code was generated with AI, it is also ok if you decide to fully ignore this PR.
(*) See Claude chat here. I used Claude Sonnet 3.7. With Sonnet 4.0 I received rate limit errors, even with a Pro account. The attached project_summary.md was generated in a different chat.