feature-complete interface #8
Conversation
krisbitney
requested review from
Niraj-Kamdar,
dOrgJelli and
namesty
as code owners
There was a problem hiding this comment.
This looks good but some of the options and methods may not be supported by all concurrency primitives
Ex: Promise do not support abort. Atleast not in the sense use expects
Similarly pausing and resuming may also be more complex and hard to achieve
We need to make sure we can effortlessly support these options and if not we can easily convey it to users.
I know I was the one who introduced some of these concepts but I think we need to revisit it
| """ | ||
| The priority level of the task. This helps determine the order in which the task will be executed. Defaults to Priority.MEDIUM if not specified. | ||
| """ | ||
| priority: Priority |
There was a problem hiding this comment.
How can we enforce this? What are some use cases of this?
| """ | ||
| The maximum number of workers that should be used to execute this task. If not specified, the system will determine the optimal number of workers. | ||
| """ | ||
| max_workers: Int |
There was a problem hiding this comment.
It might be beneficial to have max_workers available both as an argument and within the environment variables instead of either one.
This PR adds a standard interface for concurrency. This builds on the
Concurrentinterface written by @Niraj-Kamdar . The interface was updated by referencing similar interfaces in various programming languages.Please carefully review this interface and provide feedback!
Note: I am proposing that we change the name of the interface from
ConcurrenttoConcurrency.Details regarding references to features in other interfaces can be found in the issue comments: https://github.com/polywrap/std/issues/9#issuecomment-1548301252
Closes https://github.com/polywrap/std/issues/9