feat: rust implementation #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dOrgJelli
requested changes
May 18, 2023
nerfZael
reviewed
Jun 5, 2023
| } | ||
|
|
||
| #[test] | ||
| fn post_method() { |
Contributor
There was a problem hiding this comment.
This could use some form_data tests
| mod get; | ||
| mod post; | ||
|
|
||
| pub fn get_client() -> PolywrapClient { |
Contributor
There was a problem hiding this comment.
I like that we can now use the Rust client and don't have to rely on the JS client for rust wrappers.
Though, I think for most cases we could just mock the subinvocations(if any) and have unit tests instead of e2e
|
|
||
| #[plugin_impl] | ||
| impl Module for HttpPlugin { | ||
| fn get( |
Contributor
There was a problem hiding this comment.
In general for wrappers (like we talked about on the call), I'd love to see more unit tests where we mock the deps (e.g. the subinvocations or in this case the network call).
This not only helps us test the code more thoroughly and without the client dep, but also I find it helps while developing.
nerfZael
approved these changes
Jun 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.