feature-complete interface #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisbitney
requested review from
Niraj-Kamdar,
cbrzn,
dOrgJelli,
namesty,
nerfZael and
pileks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a standard interface for an HTTP client. Please carefully review this interface and provide feedback!
Based on feedback that suggested standard library interfaces should be low-level. The proposed new interface is simpler than the interface currently in production. Significant changes include:
getandpostmethods in favor of a singlerequestmethodformDataproperty from request. Form-data is now expected to be converted to string format before being sent.urlParamsandresponseTypefrom requesturlandmethodtoRequestRemoved features, like
responseType, can be implemented in a supplementary wrapper with a high-level interface. This can be done in the future either by the community or by Polywrap.Closes https://github.com/polywrap/std/issues/4