fix!: client-config-builder name #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We discussed to change the names of some of the metods in config builder to more appropiate name. Ex: addWrapper -> setWrapper Another change is renaming interface to ClientConfigBuilder from IClientConfigBuilder and rename ClientConfigBuilder to PolywrapClientConfigBuilder
Niraj-Kamdar
requested review from
dOrgJelli,
krisbitney and
namesty
as code owners
Contributor
|
Hey all, this looks good to me, but since it is a breaking change I want to first merged & released this PR: Once that's done, we can move forward with this breaking change. |
nerfZael
approved these changes
Jun 23, 2023
Contributor
|
Update: I've just realized that there exists a prior breaking change that got merged, so the next release will be a major one (v11). Going to work on merging this now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed to change the names of some of the metods in config builder to more appropiate name.
Ex: addWrapper -> setWrapper
Another change is renaming interface to ClientConfigBuilder from IClientConfigBuilder and rename ClientConfigBuilder to PolywrapClientConfigBuilder