Skip to content

Conversation

@nerfZael
Copy link
Contributor

@nerfZael nerfZael commented Jul 5, 2023

@nerfZael nerfZael requested a review from pileks July 5, 2023 23:11
@nerfZael nerfZael requested a review from dOrgJelli as a code owner July 5, 2023 23:11
Copy link
Contributor

@dOrgJelli dOrgJelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the new wrapscan/polywrap/uri-resolver@1.0 URI to the ExtendableUriResolver interfaces array so it can detect these implementations. No need to say this wrap "implements" the old interface:

public static defaultExtInterfaceUris: Uri[] = [
Uri.from("wrap://ens/wraps.eth:uri-resolver-ext@1.1.0"),
Uri.from("wrap://ens/wraps.eth:uri-resolver-ext@1.0.0"),
];

@nerfZael nerfZael requested a review from dOrgJelli July 6, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants