feat: Improved URI Inference #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity-inference # Conflicts: # packages/core/src/utils/RegExpGroups.ts
namesty
approved these changes
Jun 26, 2023
pileks
approved these changes
Jun 26, 2023
Contributor
pileks
left a comment
pileks
left a comment
There was a problem hiding this comment.
Do we see any pitfalls with such a change? For now, this seems to simplify mainly HTTP/S URIs, as the rest is pretty simple as-is.
Examples:
ipfs/Qmhashis simpler thanipfs://Qmhash(old shorter than new)fs/path/to/fileis simpler thanfile://path/to/file(old shorter than new)- HTTP/S is obviously shorter in the new system, as it mimics the actual HTTP URI
Generally, I think people are used to "browser URIs", and that this change pushes towards that.
With that in mind, and me being in favor of simplification, this gets my approval as an experimental feature!
nerfZael
approved these changes
Jun 26, 2023
Contributor
nerfZael
left a comment
nerfZael
left a comment
There was a problem hiding this comment.
Looks good.
My only nit is that parsing seems overly complex right now. It could probably be simplified.
dOrgJelli
changed the title
Contributor
Author
Working on fixing this now, we shouldn't need regex to parse the URI. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-wrap URI schemes can now be used (ex:
https://domain.com/path). The non-wrap scheme will be used as the authority, and all other contents will be shifted into the path.https://domain.com/pathintowrap://https/domain.com/pathipfs://QmHASHintowrap://ipfs/QmHASH