feat: examples #67
Merged
feat: examples #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Do we want to add CI for these examples? |
Contributor
Author
yes! thanks for pointing that out |
dOrgJelli
reviewed
Aug 9, 2023
examples/src/ethereum.ts
Outdated
| import { Wallet } from "ethers"; | ||
|
|
||
| const main = async () => { | ||
| const { uri: ethereumPluginUri } = Uri.from( |
Contributor
There was a problem hiding this comment.
NIT: I would prefer we rename to "ethereumWalletUri" and "ethereumWalletPlugin" in all examples.
Contributor
Author
There was a problem hiding this comment.
agreed, just changed it. instead of ethereumWalletPlugin i named it ethereumWalletPackage because the ethereumWalletPlugin is the variable from the @polywrap/ethereum-wallet-js package
dOrgJelli
reviewed
Aug 9, 2023
|
|
||
| // The data to sign | ||
| const message = { | ||
| from: { |
Contributor
There was a problem hiding this comment.
NIT: indentation looks to be off here.
Contributor
Author
There was a problem hiding this comment.
i think its good (just tried to format)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.