fix: remove PackageToWrapperResolver from default resolver #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dOrgJelli
requested review from
krisbitney,
namesty,
nerfZael and
pileks
as code owners
nerfZael
reviewed
Apr 26, 2023
Contributor
nerfZael
left a comment
nerfZael
left a comment
There was a problem hiding this comment.
Can you add some tests for the caching feature of the file reader?
nerfZael
requested changes
Apr 26, 2023
packages/uri-resolver-extensions/src/__tests__/uri-resolver-extension-file-reader.spec.ts
Outdated
Show resolved
Hide resolved
packages/uri-resolver-extensions/src/__tests__/uri-resolver-extension-file-reader.spec.ts
Outdated
Show resolved
Hide resolved
packages/uri-resolver-extensions/src/__tests__/uri-resolver-extension-file-reader.spec.ts
Show resolved
Hide resolved
packages/uri-resolver-extensions/src/__tests__/uri-resolver-extension-file-reader.spec.ts
Show resolved
Hide resolved
This was referenced Apr 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default resolver should not automatically convert packages to wrappers. This will allow users of the client to fetch the package when calling
client.tryResolveUri(...).Additionally, I've updated the
UriResolverExtensionFileReaderto properly cache the files it reads, avoiding needlessuriResolver.getFile(...)requests.