-
Notifications
You must be signed in to change notification settings - Fork 6
Feature: Client Config Builder #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…v of the uri if the uri is already loaded
…ihp/client_config_interfaces
…ig_builder_set_many_envs - AttributeError: 'ClientConfigBuilder' object has no attribute 'config'
|
with the current set up getting the following error: FAILED this is probably due to some syntax errors. this is how set up the various classes right now. from abc import ABC, abstractmethod
@dataclass(slots=True, kw_only=True)
class ClientConfig:
"""
This Abstract class is used to configure the polywrap client before it executes a call
The ClientConfig class is created and modified with the ClientConfigBuilder module
"""
envs: Dict[Uri, Dict[str, Any]]
interfaces: Dict[Uri, List[Uri]]
resolver: IUriResolver
class IClientConfigBuilder(ABC):
@abstractmethod
def build() -> ClientConfig:
"""Returns a sanitized config object from the builder's config."""
pass
class BaseClientConfigBuilder(IClientConfigBuilder):
"""A concrete class of the Client Config Builder, which uses the IClientConfigBuilder Abstract Base Class"""
# config: ClientConfig
def __init__(self):
self.config.envs = {}
self.config.interfaces = {}
self.config.resolver = None
...
class ClientConfigBuilder(BaseClientConfigBuilder):
...Another alternative I could try calling is |
|
The above error has been solved yesterday and now working further in the implementation of wrappers as an attribute of the just hace to do some cleanup and do a PR with WIP |
|
closing pr in favor of #52 |
Closes: #5
Continuing from #38
This PR would implement the a new
client config builderpackage, according to the recent changes of the JS Polywrap Client v0.10JS PR that implements this: polywrap/wrap-cli#1367