Skip to content

Conversation

@rihp
Copy link
Contributor

@rihp rihp commented Nov 24, 2022

Continued from #53, enables the Client Config Builder Module following the requests from @cbrzn

The new implementation uses the ClientConfig as a dataclass to later create an Abstract Base Class of a BaseClientConfigBuilder which defines more clearly the functions of the module, like add_envs, set_resolvers, remove_wrappers, and so on.

This BaseClientConfigBuilder is later used in the class ClientConfigBuilder which only implements the build method, for now, and inherits all the abstract methods of the BaseClientConfigBuilder.

Features

  • build
  • add
  • get envs
  • Set_env
  • add_env
  • add_envs
  • add interface implementations
  • set interface implementations
  • set package
  • add package
  • add packages
  • remove packages
  • add wrapper
  • add wrappers
  • remove wrapper
  • set_resolver
  • set_redirect
  • set_redirects
  • remove_redirect
  • Readme

@rihp rihp marked this pull request as ready for review November 24, 2022 15:19
@rihp rihp requested review from Niraj-Kamdar and cbrzn November 24, 2022 15:19
@rihp rihp mentioned this pull request Nov 24, 2022
12 tasks
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation isn't according to the latest js changes. Please update it to be in parity with js client

@rihp
Copy link
Contributor Author

rihp commented Nov 29, 2022

I've pushed progress again, adding more through testing, cleanups, fixtures, removing abstractclass decorators from functions with an implementation, refactored the client_config.packages property, added new tests for it, and also a first e2e test of the generic ccb.add(partial_client_config)
#54

@rihp
Copy link
Contributor Author

rihp commented Nov 29, 2022

Applied lint changes and new requests from Cesar, including the redirects and its functions

Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkout https://github.com/polywrap/toolchain/tree/origin-dev/packages/js/client-config-builder since it's been changed a lot after this PR.
Some notable changes:

  • BuilderConfig
  • Only CoreClientConfig remained
  • build signature changed

@Niraj-Kamdar Niraj-Kamdar changed the base branch from main to dev April 3, 2023 21:35
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rihp for the contributions! I have disabled the test for now but will be re-enabling when I tackle exhaustive test tasks since it requires changes due to refactors!

@Niraj-Kamdar Niraj-Kamdar merged commit b56c6b2 into dev Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants