Removal of resolution context in wrapper.invoke #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make the wrapper trait, specifically the invoke method, not coupled with the resolution context.
Resolution context passing has already been achieved through the subinvoker construct (This part was implemented in a previous PR: #94). Which means the resolution context argument is now obsolete.
Additionally, the invoke_wrapper method signature has been changed to:
The
wrapperargument has been made a reference since there was no need to keep it as Arc after the subinvoker implementation (which is an Arc itself).Less notable changes:
invoke_wrapperandinvoke_rawin the PolywrapClient now useinvoke_wrapper_rawunder the hood.