fix: build vm strategy for the arm machine #1485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrzn
previously approved these changes
Jan 18, 2023
krisbitney
approved these changes
Jan 18, 2023
Contributor
Author
Turned out this was the issue on @krisbitney side so all good |
dOrgJelli
approved these changes
Jan 18, 2023
dOrgJelli
reviewed
Jan 24, 2023
| # Install curl | ||
| RUN apt-get update | ||
| RUN apt-get -y install curl clang llvm build-essential | ||
| RUN apk add curl build-base pkgconfig openssl-dev bash |
Contributor
There was a problem hiding this comment.
Hey @Niraj-Kamdar, apologies for not asking about this before, but why are we now installing build-base, pkgconfig, openssl-dev and base?
Also I should have caught this before, but for rust builds we require clang, llvm and build-essentials to build & link native C libs.
Contributor
There was a problem hiding this comment.
One answer I found is that build-base is the alpine equivalent of build-essentials.
dOrgJelli
reviewed
Jan 24, 2023
| @@ -1,13 +1,12 @@ | |||
| FROM rust:1.65.0 as base | |||
| FROM rust:1.66-alpine as base | |||
Contributor
There was a problem hiding this comment.
Also what is the reasoning for moving to alpine?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog