fix: only include needed imported bindings in golang #1828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niraj-Kamdar
requested review from
cbrzn,
dOrgJelli,
krisbitney and
nerfZael
as code owners
dOrgJelli
requested changes
Jul 18, 2023
...s/schema/bind/src/bindings/golang/wasm/templates/env-type/Env%type%Serialization-go.mustache
Outdated
Show resolved
Hide resolved
...bind/src/bindings/golang/wasm/templates/imported/env-type/Env%type%Serialization-go.mustache
Outdated
Show resolved
Hide resolved
...rc/bindings/golang/wasm/templates/imported/object-type/Object%type%Serialization-go.mustache
Outdated
Show resolved
Hide resolved
...ma/bind/src/bindings/golang/wasm/templates/object-type/Object%type%Serialization-go.mustache
Outdated
Show resolved
Hide resolved
| go 1.18 | ||
|
|
||
| require github.com/polywrap/go-wrap wrap-0.1 | ||
| require github.com/polywrap/go-wrap v0.0.0-20230712212127-6895977d63c2 |
Contributor
There was a problem hiding this comment.
please leave as wrap-0.1
Contributor
Author
There was a problem hiding this comment.
It automatically changes to the commit version when we run go mod tidy but I will update it.
Contributor
Author
There was a problem hiding this comment.
I think We should use tag for the releases
dOrgJelli
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.