Skip to content

Conversation

@SosthenG
Copy link
Contributor

@SosthenG SosthenG commented Jun 1, 2019

@ddeboer
Copy link
Member

ddeboer commented Jun 2, 2019

Awesome, thanks for the fix!

Could you also add PHP 7.2 (and 7.3, if you want) to our Travis testing matrix?

@ddeboer ddeboer merged commit bd6d11a into portphp:master Jun 3, 2019
@ddeboer
Copy link
Member

ddeboer commented Jun 3, 2019

Thanks! We may want to give columnHeaders an empty array as default value, but this is a good fix for now.

@ddeboer
Copy link
Member

ddeboer commented Jun 3, 2019

Tagged as 1.0.1.

@ddeboer ddeboer added this to the 1.0.1 milestone Jun 3, 2019
@SosthenG
Copy link
Contributor Author

SosthenG commented Jun 3, 2019

Thanks! We may want to give columnHeaders an empty array as default value, but this is a good fix for now.

Yeah that's what I did first, but I thought that in case of an empty row, the condition would be true and that's probably not what's expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants