shiny.experimental: Deprecate card(), card_body() and card_title()#1543
Merged
shiny.experimental: Deprecate card(), card_body() and card_title()#1543
shiny.experimental: Deprecate card(), card_body() and card_title()#1543Conversation
schloerke
approved these changes
Jul 16, 2024
schloerke
force-pushed
the
cleanup/experimental-card
branch
from
3ff0f6b to
e89b154
Compare
schloerke
approved these changes
Jul 17, 2024
Collaborator
schloerke
left a comment
schloerke
left a comment
There was a problem hiding this comment.
LGTM once the card_body PR is merged.
I moved the api-example app changes to that PR
schloerke
added a commit
that referenced
this pull request
Jul 17, 2024
* main: `shiny.experimental`: Deprecate `card()`, `card_body()` and `card_title()` (#1543) Install shinylive assets instead of link Use venv for shinylive command line tool Use local build of shinylive for building doc site
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deprecates
card(),card_body()andcard_title()fromshiny.experimental.card()is now available fromshiny.ui.card(), minus thewrapperargument. If we revisit that decision, we'll move forward with the API inshiny.ui.card().feat: Export
ui.card_body()#1506 will exposecard_body()fromshiny.ui. In anticipation, this PR deprecates the experimental version, which is currently a direct import of the unexposed code inshiny.ui.experimental.ui.card_title()is simply a wrapper around atags.h5(). I feel that leaving a copy in experimental isn't needed.This leaves the experimental module with only
card_image(). I personally feel that this function provides additional value and recently worked on improving its API in bslib. In a future PR (post 1.0 release) we can consider moving this function intoshiny.ui.TODO
ui.card_body()#1506