Skip to content

Allow lint rule that contains @media (#134)#140

Merged
simonsmith merged 1 commit intopostcss:masterfrom
tardiva:dont-skip-media
Mar 25, 2019
Merged

Allow lint rule that contains @media (#134)#140
simonsmith merged 1 commit intopostcss:masterfrom
tardiva:dont-skip-media

Conversation

@tardiva
Copy link

@tardiva tardiva commented Mar 22, 2019

We are trying to start using this plugin with stylelint-bem-selector-bem-pattern for our scss. While testing it we have found some issues. One of them was described in #134.

.page {
  padding: 20px;  

  &.menu_type_main { // the linter will skip this rule
    @media (min-width: $tablet-landscape) {
      display: block;
    }
  }
}

So, we fixed it and at the same time added another improvement. Comments placed inside the rule are now ignored when extracting selectors.

@simonsmith simonsmith merged commit 520600a into postcss:master Mar 25, 2019
@simonsmith
Copy link
Collaborator

Fantastic, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants