[#235] test_pg_ctl_wait_option detects a port conflict#257
Merged
dmitry-lipetsk merged 2 commits intopostgrespro:masterfrom May 7, 2025
Merged
[#235] test_pg_ctl_wait_option detects a port conflict#257dmitry-lipetsk merged 2 commits intopostgrespro:masterfrom
dmitry-lipetsk merged 2 commits intopostgrespro:masterfrom
Conversation
This commit must fix a problem in test_pg_ctl_wait_option when his PostgreSQL instance conflicts with another one. For this, we added two new things: - PostgresNodeLogReader - PostgresNodeUtils PostgresNodeLogReader reads server logs. PostgresNodeUtils provides an utility to detect a port conflict. PostgresNode::start also uses these new classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit must fix a problem in test_pg_ctl_wait_option when his PostgreSQL instance conflicts with another one.
For this, we added two new things:
PostgresNodeLogReader reads server logs.
PostgresNodeUtils provides an utility to detect a port conflict.
PostgresNode::start also uses these new classes.