PostgresNode::is_started is RO and dynamic now#300
Closed
dmitry-lipetsk wants to merge 3 commits intopostgrespro:masterfrom
Closed
PostgresNode::is_started is RO and dynamic now#300dmitry-lipetsk wants to merge 3 commits intopostgrespro:masterfrom
dmitry-lipetsk wants to merge 3 commits intopostgrespro:masterfrom
Conversation
Collaborator
dmitry-lipetsk
commented
Dec 29, 2025
dmitry-lipetsk
commented
- We do not hold status but always get it from PG instance
- PostgresNode::start always tries to start a node
- We do not hold status but always get it from PG instance - PostgresNode::start always tries to start a node
Collaborator
Author
|
This idea is good but our internal code uses "is_started" to detected "crashed" nodes. This PR will be closed after CI checks. |
Collaborator
Author
|
A better refactoring will be done (see #301) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.