Skip to content

Key caches based on software versions#13

Merged
davecramer merged 2 commits intopostgresql-interfaces:mainfrom
apgrucza:ci-cache-by-version
May 12, 2024
Merged

Key caches based on software versions#13
davecramer merged 2 commits intopostgresql-interfaces:mainfrom
apgrucza:ci-cache-by-version

Conversation

@apgrucza
Copy link
Contributor

@apgrucza apgrucza commented May 11, 2024

This fixes the problem of the cache action incorrectly causing steps to be skipped when software versions are updated.

Note that changing the commands inside a step will not prevent that step from being skipped, but this should not be a problem once the workflow is stable. If this does occur, it can be resolved by adding a suffix to the cache key to force the creation of a new cache.

@apgrucza
Copy link
Contributor Author

The failed workflow was due to this bug in actions/cache. I've renamed the necessary cache key to work around it.

@davecramer
Copy link
Contributor

testing failed ?

@apgrucza
Copy link
Contributor Author

testing failed ?

See my comment above. Please rerun the workflow.

@davecramer davecramer merged commit bd384d4 into postgresql-interfaces:main May 12, 2024
@apgrucza apgrucza deleted the ci-cache-by-version branch May 12, 2024 12:56
@davecramer
Copy link
Contributor

I noticed that you changed it so that we aren't downloading openssl64 anymore.
We want to keep the versions of openssl the same so we need to download both 64 and 32 bit versions
EDB has version 3.0.13 of openssl

@apgrucza
Copy link
Contributor Author

I noticed that you changed it so that we aren't downloading openssl64 anymore. We want to keep the versions of openssl the same so we need to download both 64 and 32 bit versions EDB has version 3.0.13 of openssl

@davecramer Yes, I was expecting you to merge those changes from your fork, which I see you've now done. After your changes, the other caching problem I mentioned in the description of #13 has occurred and prevented the build of PostgreSQL, resulting in missing DLLs again. So I've created a new PR to address that here: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants